flathub / org.flathub.flatpak-external-data-checker

https://flathub.org/apps/details/org.flathub.flatpak-external-data-checker
0 stars 6 forks source link

Add home directory access #223

Closed bbhtt closed 1 year ago

bbhtt commented 1 year ago

Fixes https://github.com/flathub/org.flathub.flatpak-external-data-checker/issues/117

The only difference between home and host is it includes /etc, /usr at /run/host and exposes /run/media. I doubt anyone will try to update manifests in /etc or /usr or /media

flathubbot commented 1 year ago

Started test build 79258

flathubbot commented 1 year ago

Started test build 79259

flathubbot commented 1 year ago

Build 79258 was cancelled

flathubbot commented 1 year ago

Build 79259 failed

bbhtt commented 1 year ago
"errors":["appstream-missing-screenshots","appstream-failed-validation","appstream-missing-icon-file"]
flathubbot commented 1 year ago

Started test build 79262

flathubbot commented 1 year ago

Build 79262 failed

flathubbot commented 1 year ago

Started test build 79265

flathubbot commented 1 year ago

Build 79265 failed

flathubbot commented 1 year ago

Started test build 80233

flathubbot commented 1 year ago

Build 80233 failed

flathubbot commented 1 year ago

Started test build 80295

flathubbot commented 1 year ago

Build 80295 failed

flathubbot commented 1 year ago

Started test build 80311

flathubbot commented 1 year ago

Build 80311 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/62933/org.flathub.flatpak-external-data-checker.flatpakref
wjt commented 1 year ago

Personally I like this more than I like adding ad-hoc warnings on write failure.

wjt commented 1 year ago

I removed the app update from here, the checker has updated itself.

flathubbot commented 1 year ago

Started test build 80359

flathubbot commented 1 year ago

Build 80359 failed

flathubbot commented 1 year ago

Started test build 80361

bbhtt commented 1 year ago

Would you like a PR with the python manifests unified as one?

It's getting messier to manage the individual manifests as dependencies are growing.

Eg. There is already, cffi listed twice seperately. These can go out of sync quickly and cause issues down the line depending on which one gets installed first.

When everything is generated at once, pip does a basic dependency resolution that'll error out if say two modules depend on different versions of another module.

flathubbot commented 1 year ago

Build 80361 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/62985/org.flathub.flatpak-external-data-checker.flatpakref
bbhtt commented 1 year ago

Personally I like this more than I like adding ad-hoc warnings on write failure.

Yes I agree. It's not worth going down the rabbit hole of filesystem permissions and i/o errors for container/non-container cases just to print one extra hint that might not work. The inbuilt ones are pretty clear.

The issue here is the distribution method which does not give the kind of access the program expects. The access should be the default.