search

flathub / org.fritzing.Fritzing

https://flathub.org/apps/details/org.fritzing.Fritzing
1 stars 4 forks source link

Patch the .desktop file to add StartupWMClass #12

Closed stan-janssen closed 2 years ago

stan-janssen commented 2 years ago

This prevents the Dock icon from being duplicated on elemenatryOS

Please see https://github.com/elementary/dock/issues/64 for more information

gasinvein commented 2 years ago

Did you sent this patch upstream? If not, please do so.

stan-janssen commented 2 years ago

The problem only occurs when running the application as a flatpak application, so I thought is was more approprate to add it here.

gasinvein commented 2 years ago

This is a sensible change regardless of flatpak - declaring WM class explicitly won't hurt.

stan-janssen commented 2 years ago

I also offered the fix upstream, let's wait for their response.

gasinvein commented 2 years ago

bot, build

flathubbot commented 2 years ago

Queued test build for org.fritzing.Fritzing.

flathubbot commented 2 years ago

Started test build 70991

flathubbot commented 2 years ago

Build 70991 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/68840/org.fritzing.Fritzing.flatpakref
gasinvein commented 2 years ago

@stan-janssen Can you please install the test build and verify that it fixes the problem?

stan-janssen commented 2 years ago

I just installed it and it indeed fixes the problem.

As mentioned above, I also contributed this fix to the upstream fritzing-app repository.

gasinvein commented 2 years ago

Thanks!

stan-janssen commented 2 years ago

Just to be clear: if this same fix gets accepted upstream, we would have to remove the patch from this flatpak version again, correct?

gasinvein commented 2 years ago

Once upstream releases a version that includes the fix, yes.