flathub / org.gtk.Gtk3theme.Yaru

4 stars 5 forks source link

Yaru Dark Doesn't seem to work. #2

Closed ghost closed 5 years ago

ghost commented 5 years ago

For a couple days I didn't think Yaru worked at all, but it's because I had chosen the Dark version. Yaru works fine, but Yaru Dark doesn't seem to work. Don't know if this needs to be a separate package.

TingPing commented 5 years ago

It has to be a new package. If you can confirm the name of that theme I'll make it now Yaru-dark or Yaru-Dark, etc.

TingPing commented 5 years ago

Looks like -dark

ahayzen commented 5 years ago

@TingPing this is what I get in a VM when changing the theme with Tweaks.

$ gtk-query-settings |grep -i gtk-theme
                     gtk-theme-name: "Yaru"
$ gtk-query-settings |grep -i gtk-theme
                     gtk-theme-name: "Yaru-dark"
ghost commented 5 years ago

I see the same

TingPing commented 5 years ago

Repo made, will push the package soon: https://github.com/flathub/org.gtk.Gtk3theme.Yaru-dark

ghost commented 5 years ago

Thanks

TingPing commented 5 years ago

flatpak update should pull it in now.

clobrano commented 5 years ago

Yaru dark hasn't been released yet

ahayzen commented 5 years ago

@TingPing awesome thanks, it works now!

@clobrano It's in the Ubuntu 18.10 release candidate, so i assume will be officially released next week? But it's good to have in flathub as people testing the release candidate were thinking it was a bug in flatpak.

ahayzen commented 5 years ago

Ah i see the deb doesn't ship a gtk2 or Qt themes yet. But I still think it's good to have in flathub, as if a user selects Yaru-dark from GNOME Tweaks all of their apps then start using Adwaita without this. And this doesn't affect any other users, just ones who have manually chosen to use Yaru-dark.

ghost commented 5 years ago

Tested this..works like a charm now... thanks again.