Theming issues with the latest commit

har9862 commented 5 years ago

The latest commit for Yaru seems to break Flatpak theming.

The Gedit Flatpak looks like this with the latest Yaru update:

screenshot_1

$ flatpak info org.gtk.Gtk3theme.Yaru

Yaru Gtk Theme - Yaru theme

          ID: org.gtk.Gtk3theme.Yaru
         Ref: runtime/org.gtk.Gtk3theme.Yaru/x86_64/3.22
        Arch: x86_64
      Branch: 3.22
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 710,7 kB

      Commit: c3c145a672cddb1d1ac1b362eb1cd22402ed3711385829aeabd1b78d0a07d4e5
      Parent: 03e8b087a55ccfe37563df01417d60a7aed9f8a1efd0d43f5f0e7b565acc77dc
     Subject: Update org.gtk.Gtk3theme.Yaru.json (047bcfb4)
        Date: 2019-02-06 15:52:51 +0000

Reverting to the parent commit for Yaru seems to fix the issue.

$ flatpak update --commit=03e8b087a55ccfe37563df01417d60a7aed9f8a1efd0d43f5f0e7b565acc77dc org.gtk.Gtk3theme.Yaru

screenshot_2

Other Flatpaks tested like Lollypop looks also bad: screenshot_3

clobrano commented 5 years ago

Hi @har9862, thanks you! I'll revert the latest change for now, and investigate further

clobrano commented 4 years ago

Current version looks fine on Lollypop, so closing this issue

TingPing commented 4 years ago

https://github.com/flathub/org.gtk.Gtk3theme.Yaru/commit/5c887d866701fc513033ccd6c46eb6e2b5c1addc is the problem, its completely wrong and you should test your commits...

clobrano commented 4 years ago

Thanks, very clear

flathub / org.gtk.Gtk3theme.Yaru

Theming issues with the latest commit #3