flathub / org.kde.kate

https://flathub.org/apps/details/org.kde.kate
3 stars 5 forks source link

General update #24

Closed travier closed 1 year ago

travier commented 1 year ago

Revert "kate devels asked for kate to be removed"

This reverts commit fac700deb5877ce8af4c6b3daf7c902752473ea4.


Use 5.15-21.08 SDK & Platform


Update to 22.08.1 & add x-checker-data


Sort finish-args, use home only and add host access

flathubbot commented 1 year ago

Started test build 113072

flathubbot commented 1 year ago

Build 113072 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110678/org.kde.kate.flatpakref
flathubbot commented 1 year ago

Started test build 113097

travier commented 1 year ago

The terminal window has the same issues as the one in https://github.com/flathub/flathub/pull/3447 but at least it works for basic commands.

flathubbot commented 1 year ago

Build 113097 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110702/org.kde.kate.flatpakref
flathubbot commented 1 year ago

Started test build 113595

travier commented 1 year ago

Updated with a README. Looks like the terminal works great, Git integration works well.

flathubbot commented 1 year ago

Build 113595 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/111199/org.kde.kate.flatpakref
flathubbot commented 1 year ago

Started test build 2034

flathubbot commented 1 year ago

Build 2034 failed

travier commented 1 year ago

Now needs to be added to https://github.com/flathub/flatpak-builder-lint/pull/55 too

travier commented 1 year ago

bot, build

flathubbot commented 1 year ago

Queued test build for org.kde.kate.

flathubbot commented 1 year ago

Started test build 2134

flathubbot commented 1 year ago

Build 2134 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/114574/org.kde.kate.flatpakref
Waqar144 commented 1 year ago

Ping @travier

Is there anything that is blocking this?

flathubbot commented 1 year ago

Started test build 26198

travier commented 1 year ago

@Waqar144 Updated this PR. Testing and feedback are welcomed.

flathubbot commented 1 year ago

Build 26198 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8857/org.kde.kate.flatpakref
msharp1 commented 1 year ago

Build 26198 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8857/org.kde.kate.flatpakref

I was able to install the flatpak by copy/pasting the command above. Hit Enter/y when asked so then run:

flatpak run org.kde.kate

LSP seems to work fine !

A few remarks:

Waqar144 commented 1 year ago

@travier

I also tested it, most of the stuff works great.

Overall it is really good, much better than I expected. Is there someway I can build flatpaks locally to fix/debug these issues? I recall gnome builder had something like this, but not sure if it will work Kate/KDE development.

Waqar144 commented 1 year ago

I found a few more issues, some of which are fixed. Also, I had to change finish-args to

        "--filesystem=host",
        "--filesystem=/tmp",

Kate creates temporary files a lot. E.g., the new formatting plugin creates a temporary file and then diffs it with the original file and then applies a patch. That doesn't work unless I have set the above two variables

travier commented 1 year ago

I found a few more issues, some of which are fixed. Also, I had to change finish-args to

        "--filesystem=host",
        "--filesystem=/tmp",

We should probably add host. We already have that for Kwrite.

Kate creates temporary files a lot. E.g., the new formatting plugin creates a temporary file and then diffs it with the original file and then applies a patch. That doesn't work unless I have set the above two variables

It would be great if Kate could use something like xdg-run/kate instead of /tmp for temporary files.

travier commented 1 year ago

I don't really understand why we need to have /tmp shared? Is this for getting the output of applications that are run outside the Flatpak?

travier commented 1 year ago

bot, build

flathubbot commented 1 year ago

Queued test build for org.kde.kate.

flathubbot commented 1 year ago

Started test build 28372

flathubbot commented 1 year ago

Build 28372 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11039/org.kde.kate.flatpakref
travier commented 1 year ago

Let's start with that

travier commented 1 year ago

Please keep testing and reporting issues in the tracker here. Thanks!