search

flathub / org.kde.kate

https://flathub.org/apps/details/org.kde.kate
3 stars 5 forks source link

Set XDG_CURRENT_DESKTOP to kde in runtime #44

Open jrelvas-ipc opened 7 months ago

jrelvas-ipc commented 7 months ago

Currently, QT fails to theme properly for GNOME (and potentially other desktops) inside of the Flatpak runtime. Forcefully setting XDG_CURRENT_DESKTOP to "kde" fixes this behavior. This mirrors the current manifest configuration of org.kde.kdenlive.

A side-effect of this change is that the cursor will change its look from the host desktop while inside of the window, but this is preferable to the app's entire aspect looking outright broken.

Kate without XDG_CURRENT_DESKTOP defined on Gnome 45: imagem

Kate with XDG_CURRENT_DESKTOP set to kde on Gnome 45: imagem

Cursor side-effect with this change:

Gravação de ecrã a partir de 2024-01-10 18-39-38.webm

flathubbot commented 7 months ago

Started test build 92664

flathubbot commented 7 months ago

Build 92664 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/75349/org.kde.kate.flatpakref
Justinzobel commented 7 months ago

While there's obviously a small regression in the cursor, I think this is a worthwhile change.

tsdgeos commented 7 months ago

While there's obviously a small regression in the cursor, I think this is a worthwhile change.

Would be interesting to see if we can somewhat fix that without having to change every single app though

jrelvas-ipc commented 7 months ago

I think it happens because the cursor is meant to look that way on Plasma. Not sure though. For anyone on Plasma, could you check how the cursor behaves there?

A quinta, 11/01/2024, 09:53, tsdgeos @.***> escreveu:

While there's obviously a small regression in the cursor, I think this is a worthwhile change.

Would be interesting to see if we can somewhat fix that without having to change every single app though

— Reply to this email directly, view it on GitHub https://github.com/flathub/org.kde.kate/pull/44#issuecomment-1886748384, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANGL3BAYIFHB6ZEQ2M6CLRLYN6ZBHAVCNFSM6AAAAABBVIPH6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBWG42DQMZYGQ . You are receiving this because you authored the thread.Message ID: @.***>

flathubbot commented 6 months ago

Started test build 101745

flathubbot commented 6 months ago

Build 101745 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/84535/org.kde.kate.flatpakref