search

flatironinstitute / CaImAn

Computational toolbox for large scale Calcium Imaging Analysis, including movie handling, motion correction, source extraction, spike deconvolution and result visualization.
https://caiman.readthedocs.io
GNU General Public License v2.0
639 stars 370 forks source link

remove relative imports, generally clean up imports, remove dead code #1202

Closed pgunn closed 9 months ago

pgunn commented 1 year ago

This gets rid of most relative imports in the codebase and removes some dead code

EricThomson commented 1 year ago

One thing I've never thought about: why are relative imports considered bad in general, but ok in __init__.py files? Is this something we are ok with?

pgunn commented 1 year ago

I normally don't look at those because they're not really code, but they should be changed too. They're just really easy to forget about.

pgunn commented 9 months ago

I let this sit for too long and am going to redo this diff against the current dev branch, taking into account some of the feedback and rolling back a few things (and adjusting others). Will hold this PR open until the diff that comes from it lands, to act as a reference for the redo.

pgunn commented 9 months ago

Closing this because it became too stale to easily fix; succeeded by #1277