flatironinstitute / CaImAn

Computational toolbox for large scale Calcium Imaging Analysis, including movie handling, motion correction, source extraction, spike deconvolution and result visualization.
https://caiman.readthedocs.io
GNU General Public License v2.0
639 stars 370 forks source link

Remove slurm integration #1233

Closed pgunn closed 1 year ago

pgunn commented 1 year ago

Based on: A) Looking over the code carefully and determining that it hasn't been tested since the Python 2.7 days and that it B) Doesn't work with the modern codebase C) Is undocumented D) In the last released version of Caiman had dependencies on andrea's home directory hardcoded E) Even if it were fully fixed would almost never provide a performance benefit given current levels of parallelism F) And is really ugly/weird

this diff removes the old slurm integration from the code.

To be clear: some of our users run Caiman under slurm. This removal does not impact them because nobody we could find was using the slurm integration (given how broken it was and specific to our local cluster, it's unclear how they might've gotten it working). They were just allocating a node under slurm and running caiman on it, which is the same as running any other software on a node. Caiman doesn't notice SLURM by default and doesn't mind its specifics.

pgunn commented 1 year ago

Resolves #1213