flatironinstitute / CaImAn

Computational toolbox for large scale Calcium Imaging Analysis, including movie handling, motion correction, source extraction, spike deconvolution and result visualization.

https://caiman.readthedocs.io

GNU General Public License v2.0

639 stars 370 forks source link

Fix incompatibilities in test_sbx for python <3.11 #1314

Closed ethanbb closed 7 months ago

ethanbb commented 7 months ago

Description

Fixes build error in #1311

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Has your PR been tested?

caimanmanager test passes on 3.11 - if any invalid syntax for <3.11 remains, should be caught in CI

ethanbb commented 7 months ago

Well looks like the nice type annotation syntax doesn't work on 3.9... updating now

pgunn commented 7 months ago

At least stuff like this reminds us that python is getting better! I think there were just some upstream packaging issues that currently block us from switching over (tensorflow and one other thing, I think); when we do I'm looking forward to going through the codebase and modernising the syntax (my favourite kind of diff to work on)

pgunn commented 7 months ago

Thanks! I'll be cutting a new release shortly (today or tomorrow); mostly a bugfix for the thing you found earlier that I thought was already out, but your sbx fix here will also be part of it; you won't need to use a compiled build for very long (unless you want to).

ethanbb commented 7 months ago

Great, thank you for being so responsive and helping me get this out!

kushalkolar commented 7 months ago

I'm think this is py3.10+ https://peps.python.org/pep-0604/

according to NEP 29 python3.9 support stops in numpy on April 5 so it's not too far out, but tensorflow usually lags behind quite a bit.