search

flatironinstitute / CaImAn

Computational toolbox for large scale Calcium Imaging Analysis, including movie handling, motion correction, source extraction, spike deconvolution and result visualization.
https://caiman.readthedocs.io
GNU General Public License v2.0
639 stars 370 forks source link

Logging cleanup #1378

Closed pgunn closed 4 months ago

pgunn commented 4 months ago

This implements #1376 and addresses #1374

It moves almost all use of logging to use a named logger rather than the base logger. This allows code that calls caiman to have different log levels than caiman does, giving the user more control over logging.

I included some minor cleanups of things I saw along the way (like f-string conversions and import cleanups), and updated the docs on the logger (which were incorrect even before this diff; they suggested a logger format that's not valid)

As I write this: 1) I need to modify the jupyter notebooks too 2) Need to see if this passes CI 3) Will need to look at the diff a little more to make sure I didn't miss adding the code to reach the named logger I added to functions/methods

I'll push another revision to this to deal with the first, at least, and anything I need to change for the second and third

pgunn commented 4 months ago

Second and third concerns are taken care of. I still need to loop back and adjust the jupyter notebooks. Will do that either later tonight or tomorrow.