search

flatpak / flatpak-xdg-utils

Simple portal-based commandline tools for use inside flatpak sandboxes
GNU Lesser General Public License v2.1
32 stars 14 forks source link

flatpak-spawn: Use headers copied from Flatpak for most constants #56

Closed smcv closed 2 years ago

smcv commented 2 years ago

This assumes https://github.com/flatpak/flatpak/pull/4531 is applied.

TingPing commented 2 years ago

Would a submodule make more sense, just easier to keep in sync.

smcv commented 2 years ago

Would a submodule make more sense, just easier to keep in sync

I'd rather not have a shared submodule for 2 headers, and I don't think we want to submodule in all of Flatpak just to build flatpak-xdg-utils?

flatpak-spawn is only going to need updates to these headers if they're necessary when giving it new features, and new features need new C code in flatpak-spawn anyway, which seems like a natural time to do the header update. For instance, the last time I updated these enums was in 27f293aa while adding the --share-pids feature.