flatpak / xdg-desktop-portal-gtk

Gtk implementation of xdg-desktop-portal
GNU Lesser General Public License v2.1
130 stars 102 forks source link

settings: Implement the contrast settings #466

Closed hfiguiere closed 9 months ago

hfiguiere commented 10 months ago

See https://github.com/flatpak/xdg-desktop-portal/pull/1175

Note: I still have questions how this work on a non GNOME system.... so it might not be relevant.

Mostly a cut and paste of https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/143

TingPing commented 10 months ago

Note: I still have questions how this work on a non GNOME system.... so it might not be relevant.

This is the only setting GTK looks at to detect high contrast. Other desktops have to set the GSetting. KDE already sets various GSettings for theme, not sure if they set this one too but that would be changed there.

dominichayesferen commented 10 months ago

Note: I still have questions how this work on a non GNOME system.... so it might not be relevant.

This is the only setting GTK looks at to detect high contrast. Other desktops have to set the GSetting. KDE already sets various GSettings for theme, not sure if they set this one too but that would be changed there.

For the record, last I checked they don't... because they don't have High Contrast in that regard yet (until now, the most they have had is an ill-fated Breeze Dark colour scheme edit).