search

flavorjones / loofah

Ruby library for HTML/XML transformation and sanitization
MIT License
934 stars 138 forks source link

Add flex properties to safelist #198

Closed miguelperez closed 4 years ago

miguelperez commented 4 years ago

I submitted the question as an issue, but then figured it is better to submit a PR. https://github.com/flavorjones/loofah/issues/197

https://css-tricks.com/snippets/css/a-guide-to-flexbox/

flavorjones commented 4 years ago

@miguelperez Thanks so much for the kind PR, and especially thanks for the idiomatic test coverage!

Here are the properties being added, with links to the MDN docs for each:

Generally speaking, this PR looks good, I just want to spend some time to understand each of these properties (primarily to ensure we're not introducing any security risk) but based on the names and concepts I think that's unlikely to raise any issues.

Optimistically, I should have time to review and merge, and cut a release by the end of the week.

miguelperez commented 4 years ago

glad to help.

flavorjones commented 4 years ago

Shipped in https://github.com/flavorjones/loofah/releases/tag/v2.8.0!

Thanks again.