This issue tracks the recent changes made in the system, focusing on the refactoring of email and phone existence checks and improvements in localization support. The following updates were made:
Added EmailAddressExistsResponse and EmailAddressNotExistsResponse.
Added PhoneNumberExistsResponse and PhoneNumberNotExistsResponse.
Added localization messages to messages_en_US.properties and messages_fr.properties.
Refactored MemberServiceImpl to return EntityExistsResponse for isMemberEmailAddressExists and isMemberPhoneNumberExists methods.
Refactored MiscController to replace the use of EmailService and PhoneService with MemberService.
Steps to Review:
Verify that the EmailAddressExistsResponse and EmailAddressNotExistsResponse work as expected.
Verify that the PhoneNumberExistsResponse and PhoneNumberNotExistsResponse work as expected.
Confirm that the localization messages for both English and French (messages_en_US.properties and messages_fr.properties) are correctly set up and resolve properly based on user locale.
Review the refactoring of MemberServiceImpl to ensure that it returns the appropriate responses for email and phone existence checks.
Ensure the MiscController properly interacts with MemberService for email and phone checks.
Impact:
Improved consistency by consolidating email and phone checks in MemberService.
Enhanced localization for both English and French users.
Description:
This issue tracks the recent changes made in the system, focusing on the refactoring of email and phone existence checks and improvements in localization support. The following updates were made:
EmailAddressExistsResponseandEmailAddressNotExistsResponse.PhoneNumberExistsResponseandPhoneNumberNotExistsResponse.messages_en_US.propertiesandmessages_fr.properties.MemberServiceImplto returnEntityExistsResponseforisMemberEmailAddressExistsandisMemberPhoneNumberExistsmethods.MiscControllerto replace the use ofEmailServiceandPhoneServicewithMemberService.Steps to Review:
EmailAddressExistsResponseandEmailAddressNotExistsResponsework as expected.PhoneNumberExistsResponseandPhoneNumberNotExistsResponsework as expected.messages_en_US.propertiesandmessages_fr.properties) are correctly set up and resolve properly based on user locale.MemberServiceImplto ensure that it returns the appropriate responses for email and phone existence checks.MiscControllerproperly interacts withMemberServicefor email and phone checks.Impact:
MemberService.