Add automation to run all unit tests on Windows and make sure all tests pass.

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)

https://fleetdm.com

Other

3.16k stars 433 forks source link

Add automation to run all unit tests on Windows and make sure all tests pass. #10649

Open sharon-fdm opened 1 year ago

sharon-fdm commented 1 year ago

Goal

As the developers of all code in Fleet repositories we would like the unit tests to be run on a Windows machine to test the Windows code parts as well so that we can trust our unit tests to catch Win related issues.

Changes

The current workflow only runs Ubuntu. Need to change that.

Scope

Make sure all tests pass when running on Windows.
Add Windows to the automation so that it runs on every PR.

zayhanlon commented 1 year ago

Impact: Broken code QA can't test every aspect of every issue/PR. We rely on automation to check all the old code. Currently there's a lot of code which is not being tested. Some code is shared between WIN and Mac, some is macOS only. We skip a large chunk of QA automation.

lucasmrod commented 1 year ago

My comment for the macOS issue applies here too: https://github.com/fleetdm/fleet/issues/10650#issuecomment-1480899327.

Estimated at 2pts assuming option 1 in the comment above. Basically start simple with a test-go-windows.yml and run a subset of the tests that do not require Docker (MySQL/Redis).

zhumo commented 1 year ago

Hi @sharon-fdm , unfortunately we are unable to complete this work in the 6 week SLA. Please feel free to bring this back to Feature Fest if it still remains a priority for stakeholders.

sgress454 commented 5 days ago

See also https://app.zenhub.com/workspaces/help-engineering-672a4556609a0d000f391584/issues/gh/fleetdm/fleet/3036, about testing fleetctl and Orbit on Windows and MacOS. That may be be a higher priority if the server itself is mainly expected to run on Linux machines.