fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.15k stars 431 forks source link

Add bytes option for Windows MDM config #13033

Closed noahtalerman closed 1 year ago

noahtalerman commented 1 year ago

Goal

User story
As a Fleet contributor,
I want to be able to set the required configuration option values as bytes
so that I can dogfood Windows MDM features.

Changes

Context

While the file path options work great during development, it's difficult to have the dogfood environment accept the file path options.

This is just a fix for dogfooding Windows MDM. The plan for launch is to auto magically generate and apply these certs for the user. This will take significant effort and we want to unblock dogfooding sooner.

Engineering

Product quality

Context

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming succesful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming succesful completion of QA.
georgekarrv commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314 @roperzh

sabrinabuckets commented 1 year ago

@gillespi314 I thought this morning that I had a better handle on how to test this, but after a couple of discussions I realize I do not. Any chance we can get a call together tomorrow to run through it?

sabrinabuckets commented 1 year ago

Validated able to successfully start Fleet and enroll a Windows host into MDM with the BYTES env variables.

Additional testing notes: Tested with incorrect env var formatting and received expected error. Tested with incorrect values set & received expected error. Tested starting with the cert variable set & key flag, received an error. Tested with key variable set & cert flag, was able to run Fleet successfully.

zhumo commented 1 year ago

C&C Hey @gillespi314 would you document these changes? cc @noahtalerman

noahtalerman commented 1 year ago

UPDATE: Hey @gillespi314, @ireedy is writing the docs for these changes.

noahtalerman commented 1 year ago

Confirm and celebrate: @ireedy just checking in, how are docs going?

ireedy commented 1 year ago

@noahtalerman PR submitted for your review!

ireedy commented 1 year ago

C&C: can close!

fleet-release commented 1 year ago

Config bytes now set, Unblocks Windows MDM test, Progress without fret.