search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.16k stars 432 forks source link

Awkward empty state alignment + text wrapping on settings pages #23027

Open rachaelshaw opened 1 month ago

rachaelshaw commented 1 month ago

Fleet version: 4.58.0

💥  Actual behavior

Because the settings pages have a different layout than the rest of the app, the alignment of the empty states looks a little strange. Also, the text wrapping looks a little odd with >1 paragraphs. See Settings > Integrations > Ticket destinations: Screenshot 2024-10-18 at 4 42 28 PM

🧑‍💻  Steps to reproduce

  1. TODO
  2. TODO

🕯️ More info (optional)

N/A

🛠️ To fix

Wrap settings page > side nav empty messages in a box that fills the full available width Figma

jacobshandling commented 2 weeks ago

Just want to double-check, we want this for all empty states under /settings, including this one? Screenshot 2024-11-08 at 2 37 27 PM

jacobshandling commented 2 weeks ago

@rachaelshaw ^ ?

rachaelshaw commented 4 days ago

@jacobshandling only the ones on pages with a side nav

jacobshandling commented 4 days ago

Thanks @rachaelshaw