fleetdm / fleet

Open device management
https://fleetdm.com
Other
5.22k stars 611 forks source link

fix: Include Software URLs in fleet generate-gitops when software has URL #30177

Closed drvcodenta closed 2 weeks ago

drvcodenta commented 3 weeks ago

fixes: https://github.com/fleetdm/fleet/issues/29617

Checklist for submitter

I implemented support for exporting the url field in fleetctl generate-gitops when it's available in the software installer metadata. During testing, I found that although some Fleet-maintained apps (like Brave and Cloudflare WARP) show URLs in the UI, those URLs are not persisted to the database—hence they don’t appear in the generated YAML unless added manually. I confirmed the url field is supported in the database and properly handled in the insertion logic. The version field does get populated when the software is installed on a host. This patch completes the GitOps export part, but the root issue may lie in the ingestion flow of the url.

image

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.88%. Comparing base (cca4d24) to head (dcf043e). Report is 148 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30177 +/- ## ========================================== - Coverage 64.11% 57.88% -6.23% ========================================== Files 1865 1835 -30 Lines 182319 174885 -7434 Branches 5253 5253 ========================================== - Hits 116896 101237 -15659 - Misses 56223 65799 +9576 + Partials 9200 7849 -1351 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/30177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/fleetdm/fleet/pull/30177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `58.20% <ø> (-6.86%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
drvcodenta commented 2 weeks ago

sure

drvcodenta commented 2 weeks ago

Created the issue: https://github.com/fleetdm/fleet/issues/30282