fleetdm / fleet

Open device management
https://fleetdm.com
Other
5.23k stars 617 forks source link

Browser breaks when installing FMA browser app when the browser is open #30195

Closed zayhanlon closed 2 weeks ago

zayhanlon commented 3 weeks ago

UPDATE: @noahtalerman: We closed this feature request in favor of this bug:



iansltx commented 3 weeks ago

@zayhanlon This feels like it should be a bug? Seems like what we should be doing here (and I realize this ticket got rephrased, hence my taking liberties with a different suggested fix) is:

  1. Revise FMA browser install scripts to reliably quit the application when it's installed, and ensure that that gets us a successful in-place reinstall
  2. In the self-service UI, give end users a heads-up that if they install an already-installed app, their existing app will be exited if it's open. We could limit this confirmation (probably a modal?) to just specific apps with some extra piping, or apply to any app that's being reinstalled when it's already in inventory. This work probably makes sense to do as part of #30214 since the same UI will be getting reworked for both of these changes.

Does that make sense? Seems like an approach we can standarize on for other apps/types of apps as needed, vs. needing to exclude certain apps from self-service (or self-service update).

iansltx commented 3 weeks ago

But also, at the very least having a broken browser at the end of what looked like a successful install feels like a bug, and the last time something came up like this it was classified as a bug (#24148).

noahtalerman commented 2 weeks ago

FYI @zayhanlon we closed this feature request in favor of this bug:

fleet-release commented 2 weeks ago

FMA app installs, Browser no longer falters, Peace in cloud city halls.