Cannot access installable software when using the "Turn off teams" feature, various other UI edge cases

ksatter commented 2 weeks ago

Fleet version: v4.69.0

Web browser and operating system:

💥 Actual behavior

1) Can't access installable software:

After enabling the FLEET_PARTNERSHIPS_ENABLE_PRIMO configuration added for #28221, customer-preston is unable to view installable applications without manually adding 'team_id=0` to the URL.

See video example here:

https://fleetdm.slack.com/archives/C061ZA91Y1J/p1750431864258739?thread_ts=1750431629.326919&cid=C061ZA91Y1J

🧑‍💻 Steps to reproduce

Upload software to "No Team"
Enable FLEET_PARTNERSHIPS_ENABLE_PRIMO
Navigate to Software tab
Filter by "Available for install

UI

🛠️ To fix

- Default and redirect to No team (team_id=0) or All teams when Primo mode enabled, whichever preservers full "Premium" functionality of each page
- ~If feasible, keep team_id=0 out of the URL~
- Handle resulting UI edge cases

QA

Ensure that in Primo mode an admin can access installable software without manually having to edit the URL team_id query param
Ensure team functionality is unaffected when not in Primo mode - on each page and each settings page, try changing teams and poking around, look for any unexpected behavior

jacobshandling commented 2 weeks ago

I’m going to assume the requirements here are:

Default and redirect to No team (team_id=0) everywhere when Primo mode enabled
If feasible, keep team_id=0 out of the URL while we’re at it Estimate 2-3

@ksatter @noahtalerman please let me know exactly what the requirements are if not these

noahtalerman commented 2 weeks ago

I’m going to assume the requirements here are:

Default and redirect to No team (team_id=0) everywhere when Primo mode enabled

If feasible, keep team_id=0 out of the URL while we’re at it Estimate 2-3

@ksatter @noahtalerman please let me know exactly what the requirements are if not these

Up to @rachaelshaw

cc @jacobshandling

ksatter commented 2 weeks ago

I think that just defaulting to "No Team" is a reasonable solution., FWIW.

valentinpezon-primo commented 2 weeks ago

I’m going to assume the requirements here are:

Default and redirect to No team (team_id=0) everywhere when Primo mode enabled

If feasible, keep team_id=0 out of the URL while we’re at it Estimate 2-3

@ksatter @noahtalerman please let me know exactly what the requirements are if not these

Yes, always default to team 0 - everywhere it's needed 👍

jmwatts commented 2 weeks ago

QA Notes

with FLEET_PARTNERSHIPS_ENABLE_PRIMO=true:

[x] Confirm Software page allows filtering by "All software", "Available for install", "Self-service"
[x] Filtering by "Available for install" shows software that has been previously uploaded and is available to be installed.
[x] "Add software" button is shown and we can add new software to the library
[x] When clicking on a software that has already been added to the library, no team dropdown is displayed on the software title page
[x] Also confirmed if I get to a page that has a team dropdown (Settings >> Teams >> Click on a team name) and then navigate to other main pages (tested Hosts, Controls, Software, Queries, Policies), we are defaulted back to ?team_id=0
[x] Confirmed the text in the "Manage enroll secret" modal on the hosts page now says "Use these secret(s) to enroll hosts:"
[x] Confirmed going to Settings -> Teams and clicking on a previously-created team no longer shows a 500 page.

I did see in an earlier comment:

If feasible, keep team_id=0 out of the URL while we’re at it

but I didn't see that when testing. ?team_id=0 showed up in the url when navigating around.

Per the notes on the PR there are two main caveats to this revision:

Software page: [Without the environment variable] Software automations are only accessible via All teams, while Add software is only accessible on a team, including No team. [With the environment variable enabled] the Add software functionality is available. The Software automations functionality is not available with this revision. Enabling both functionalities with the environment variable enabled will need to go through a proper drafting process, since Fleet doesn’t currently support both in any state.
Policies page: [Without the environment variable] “Other workflows” (tickets and webhooks) automations are available on All Teams and specific teams, but not on No Team. [With the environment variable enabled] “Other workflows” is currently unavailable in this revision. If any policies were created on All Teams prior to enabling the environment variable, the option to manage ticket or webhook automations for them will not longer be available. All Teams policies can only have ticket/webhook workflows.

fleet-release commented 1 week ago

Fixing URL, like paths in clouds, Software seen, no more shrouds. Quietly enhancing flow.

fleetdm / fleet