fleetdm / fleet

Open device management
https://fleetdm.com
Other
5.22k stars 612 forks source link

Update windows CSP verification logic #30203

Closed JordanMontgomery closed 2 weeks ago

JordanMontgomery commented 2 weeks ago

Fixes #28499

Checklist for submitter

If some of the following don't apply, delete the relevant line.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 58.95%. Comparing base (30e9f85) to head (482e0a5). Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
server/mdm/microsoft/profile_verifier.go 0.00% 30 Missing :warning:
server/service/osquery_utils/queries.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30203 +/- ## ========================================== - Coverage 64.21% 58.95% -5.26% ========================================== Files 1869 1705 -164 Lines 182716 165057 -17659 Branches 5352 5352 ========================================== - Hits 117324 97310 -20014 - Misses 56180 60016 +3836 + Partials 9212 7731 -1481 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/30203/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/fleetdm/fleet/pull/30203/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `59.33% <0.00%> (-5.76%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
JordanMontgomery commented 2 weeks ago

Test failures are unrelated apparently flaky tests, one of which is a known issue with a VPP token having expired