search

fleetdm / fleet

Open device management
https://fleetdm.com
Other
5.22k stars 611 forks source link

Fleet UI: Host software followup #30205

Closed RachelElysia closed 2 weeks ago

RachelElysia commented 2 weeks ago

Issue

For #29728

Description

Continuation to:

Screenrecordings of additions

https://github.com/user-attachments/assets/8de3154a-99d1-457d-9604-aebf7d182c28

https://github.com/user-attachments/assets/44ec9df4-ada1-4e31-b514-bd1e54f9f0a2

Checklist for submitter

If some of the following don't apply, delete the relevant line.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.

Project coverage is 64.20%. Comparing base (3715545) to head (eb7d1d8). Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...Titles/SoftwareTable/SoftwareTitlesTableConfig.tsx 0.00% 5 Missing :warning:
...details/cards/Software/HostSoftwareTableConfig.tsx 0.00% 5 Missing :warning:
...er/DataTable/SoftwareNameCell/SoftwareNameCell.tsx 91.66% 2 Missing :warning:
...tails/cards/Software/DeviceSoftwareTableConfig.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30205 +/- ## ========================================== + Coverage 64.18% 64.20% +0.02% ========================================== Files 1867 1869 +2 Lines 182492 182689 +197 Branches 5159 5314 +155 ========================================== + Hits 117129 117295 +166 - Misses 56149 56183 +34 + Partials 9214 9211 -3 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/30205/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [frontend](https://app.codecov.io/gh/fleetdm/fleet/pull/30205/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `54.58% <70.45%> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
RachelElysia commented 2 weeks ago

~350 lines are tests