search

flexn-io / renative

🚀🚀🚀 Unified Development Platform for iOS, tvOS, Android, Android TV, Android Wear, Web, Tizen TV, Tizen Watch, Tizen Mobile, LG webOS, macOS/OSX, Windows, KaiOS, FirefoxOS Firefox TV platforms
https://renative.org
MIT License
1.81k stars 180 forks source link

[android, androidtv] `npx rnv run -p android -t non-existing IP:port` works differently on different OS #1610

Open GabrieleKaceviciute opened 3 months ago

GabrieleKaceviciute commented 3 months ago

Describe the bug Both npx rnv run -p android -t non-paired-device-IP and -t non-existing-IP asks to pair device on macOS and Linux. On windows -> -t non-paired-device-IP asks to pair device. -t non-existing-IP -> asks to pick available target

To Reproduce

  1. Go to template-starter package
  2. Do npx rnv run -p android -t non-paired-device-IP -> asks to pair device (macos, linux, windows)
  3. Do npx rnv run -p android -t non-existing-IP -> asks to pair device (macos, linux); asks to pick available target (windows)

Expected behavior -t non-existing-IP -> asks to pick available target on all OS

Desktop (please complete the following information):

RicardasN commented 3 months ago

This seems to be related to adb behaviour. Having worked on this I was not able to get macOS to find the device on the network, therefore it always resulted in asking for a pick of an emulator, using non-existing IP address was the same, therefore it means I cannot recreate the bug on my machine.

aurimasmi commented 1 month ago

@pauliusguzas @GabrieleKaceviciute can you try to re-test it with latest live release. @RicardasN please put version which you tried to reproduce this ticket against

pauliusguzas commented 1 month ago

1.1.0-rc.0

this is what I get on mac when using non existing ip address

pauliusguzas@MBP-de-Flexn app-harness % npx rnv run -p android -t 111.111.111.111

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.0.0 | renative.org | 8/27/2024, 11:09:59 AM              │
│ $ rnv run -p android -t 111.111.111.111                         │
└─────────────────────────────────────────────────────────────────┘
info: Current platform: android
info: Current engine: @rnv/engine-rn (../engine-rn)
task: ○ run ↺1
info: Build hooks not complied. BUILDING...
task: ○ configure ↺1
task: ○ platform configure ↺1
task: ○ project configure ↺1
info: Creating folder ./platformBuilds ...DONE
task: ○ workspace configure ↺1
task: ✔ workspace configure
task: ○ app configure ↺1
? Which one would you like to pick? harness
info: Current app config: harness
task: ✔ app configure
info: ✔ /@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/overrides@11.3.7.json. FIXING...DONE
info: ✔ /@react-native-community/cli/build/bin.js requires override by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json. FIXING...DONE
info: ✔ /react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
info: ✔ /react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
info: ✔ /react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js requires override by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json. FIXING...DONE
info: ../../node_modules/react-native-photo-editor overriden by: /@rnv/config-templates/pluginTemplates/react-native-photo-editor/overrides
task: ✔ project configure
info: Current Build Scheme: debug
task: ○ sdk configure ↺1
task: ✔ sdk configure
task: ✔ platform configure
info: Found custom assetSources at ../../node_modules/@flexn/assets-renative-outline/assets/android. Will be used to generate assets.
task: ✔ configure
✔ Executing: "/Users/pauliusguzas/Library/Android/sdk/platform-tools/adb" connect 111.111.111.111:5555
warn: ○ run: You'll need to pair your device before installing app.
For more information: https://developer.android.com/studio/run/device
? Please go to Settings, enable debugging, and enter the IP address and Port req
uired for pairing:

this is what I get on windows

PS C:\Users\dev\Desktop\hello-renative> npx rnv run -p android -t 111.111.111.111

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ $ rnv run -p android -t 111.111.111.111                         │
└─────────────────────────────────────────────────────────────────┘
info: Current platform: android
info: Current engine: @rnv/engine-rn (C:\Users\dev\Desktop\hello-renative\node_modules\@rnv\engine-rn)
task: ○ run ↺1
task: ○ configure ↺1
task: ○ platform configure ↺1
task: ○ project configure ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
task: ○ app configure ↺1
info: Current app config: app
task: ✔ app configure
info: C:\Users\dev\Desktop\hello-renative\node_modules\@react-native-community\cli-platform-ios\build\tools\listIOSDevices.js overriden by: \@rnv\config-templates\pluginTemplates\@react-native-community\cli-platform-ios\overrides@11.3.7.json
info: C:\Users\dev\Desktop\hello-renative\node_modules\@react-native-community\cli\build\bin.js overriden by: \@rnv\config-templates\pluginTemplates\@react-native-community\cli\overrides.json
info: C:\Users\dev\Desktop\hello-renative\node_modules\react-native-tvos\Libraries\Components\ScrollView\ScrollViewNativeComponent.js overriden by: \@rnv\config-templates\pluginTemplates\react-native-tvos\overrides.json
info: C:\Users\dev\Desktop\hello-renative\node_modules\react-native-tvos\Libraries\Components\ScrollView\ScrollViewNativeComponent.js overriden by: \@rnv\config-templates\pluginTemplates\react-native-tvos\overrides.json
info: C:\Users\dev\Desktop\hello-renative\node_modules\react-native-tvos\Libraries\Components\ScrollView\ScrollViewNativeComponent.js overriden by: \@rnv\config-templates\pluginTemplates\react-native-tvos\overrides.json
task: ✔ project configure
info: Current Build Scheme: debug
task: ○ sdk configure ↺1
task: ✔ sdk configure
task: ✔ platform configure
info: Found custom assetSources at C:\Users\dev\Desktop\hello-renative\node_modules\@flexn\assets-renative-outline\assets\android. Will be used to generate assets.
task: ✔ configure
√ Executing: "C:\Users\dev\AppData\Local\Android\sdk\platform-tools\adb.exe" connect 111.111.111.111:5555
√ Executing: "C:\Users\dev\AppData\Local\Android\sdk\platform-tools\adb.exe" devices -l
√ Executing: "C:\Users\dev\AppData\Local\Android\sdk\emulator\emulator.exe" -list-avds
√ Waiting for emulator to boot...
√ Executing: "C:\Users\dev\AppData\Local\Android\sdk\platform-tools\adb.exe" -s emulator-5554 shell wm size
√ Executing: "C:\Users\dev\AppData\Local\Android\sdk\platform-tools\adb.exe" -s emulator-5554 shell wm density
√ Executing: "C:\Users\dev\AppData\Local\Android\sdk\platform-tools\adb.exe" -s emulator-5554 shell getprop
info: The target is specified, but no such emulator or device is available: 111.111.111.111. Will try to find available one
? What target would you like to use? (Use arrow keys)
> Pixel_4_API_29 | Phone 📱  | arch: x86 | udid: emulator-5554  (active)