search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Uniformly remove all zk cruft when we delete a webhook #1120

Closed lkemmerer closed 5 years ago

lkemmerer commented 5 years ago

We delete webhooks in a couple places and have some ZK state that we don't currently clean up consistently, so this fixes that. This doesn't affect prod much, since we don't delete webhooks that often, but dev had a pretty massive number of orphaned webhook state.

Other than the first commit bug fix, there's some pretty serious refactoring to WebhookError, which might not have been strictly necessary, but the single test it had bugged me and I wanted to use the ZK utils class there, too.

lkemmerer commented 5 years ago

@crozierm I think I addressed all of your concerns.