increase s3 request timeout, emit metrics/logs on timeout

flightstats / hub

fault tolerant, highly available service for data storage and distribution

http://www.flightstats.com

MIT License

103 stars 35 forks source link

increase s3 request timeout, emit metrics/logs on timeout #1124

Closed Paul-Hess closed 5 years ago

lkemmerer commented 5 years ago

Is 2 minutes going to be enough? Also: you've got great instincts for finding bugs. :) Assuming everyone's happy with that timeout time, I'm cool with merging and can be around if we need to do a deploy,

Paul-Hess commented 5 years ago

That's an excellent question, I was supposed to change it to be configurable in pairing with Crozier, and we started down a rabbit hole from there, from which we decided to take a step back until after a longer consultation with you on scope, I'll add that one change in before merging

lkemmerer commented 5 years ago

Looks good, thanks for making it configurable!