search

flightstats / hub

fault tolerant, highly available service for data storage and distribution
http://www.flightstats.com
MIT License
103 stars 35 forks source link

Metrics filter #1135

Closed Paul-Hess closed 5 years ago

Paul-Hess commented 5 years ago

Yeah it's big, but more than half is changing the name of metricsService to statsdReporter and deleting unused class cruft. This contains commits from #1127 so is opened against that until it goes to master

The real guts of it: Refactors the "metrics service", separating some of it's concerns and updating how it is instantiated to how we like to do things, names it statsdReporter for our current naming conventions.

Adds the ability to filter clients in the statsdReporter and report to one or both of them.

Adds tests around all the new things.

breaks out the lifecycle logic, calls the lifecycles lifecycle, registers the lifecycles outside of their constructors

lkemmerer commented 5 years ago

Is it best to look at the whole diff at once, or to go commit-by-commit?

Paul-Hess commented 5 years ago

I think you're better off doing the whole diff it once