search

flipperbw / FantasyPlus

Adds FantasyPros projections to fantasy football sites.
Mozilla Public License 2.0
88 stars 38 forks source link

added functionality to remove ads from the freeagency page #10

Closed LaCodeA closed 9 years ago

LaCodeA commented 9 years ago

With the added columns on the 'freeagency' page, the ads block off some of the columns. This addition removes the ads from the page.

flipperbw commented 9 years ago

My only issue with doing it this way is that ESPN might complain about it. Adblock prevents the calls from ever being made, whereas this method will still force the advertiser to pay for what would essentially be impression fraud. :(

I need to find a different way to smush them to the sides so they don't overlap. It shouldn't be too hard to do that, I just haven't messed with the css yet.

LaCodeA commented 9 years ago

I thought about that as well. I will work on moving them to the sides, thanks for the fast response. Also, thanks so much for creating this amazing plugin, found it on reddit, you are a hero my friend! I will also look at the other feature requests that you are looking into and do my best to contribute as much as I can.

-Lakota

On Wed, Dec 3, 2014 at 7:29 PM, flipperbw notifications@github.com wrote:

My only issue with doing it this way is that ESPN might complain about it. Adblock prevents the calls from ever being made, whereas this method will still force the advertiser to pay for what would essentially be impression fraud. :(

I need to find a different way to smush them to the sides so they don't overlap. It shouldn't be too hard to do that, I just haven't messed with the css yet.

— Reply to this email directly or view it on GitHub https://github.com/flipperbw/FantasyPlus/pull/10#issuecomment-65528541.

flipperbw commented 9 years ago

Okay, I got it. Check the recent commit and let me know if that works.

flipperbw commented 9 years ago

And thanks for the help! Always appreciated.