flobz / psa_car_controller

Control psa car with connected_car v4 API.
GNU General Public License v3.0
425 stars 225 forks source link

ABRP HTTPS warning in Log #713

Open kurim opened 10 months ago

kurim commented 10 months ago

Describe the bug After adding ABRP log shows warning message

To Reproduce Steps to reproduce the behavior:

  1. add ABRP Token + Enable ABRP
  2. while contacting ABRP API
  3. Does it persist after restarting the program? Yes

Config file Give the anonymize content of the config file

Environment (please complete the following information):

Unverified HTTPS request is being made to host 'api.iternio.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings


I guess you can solve it by updating [abrp.py at line 55](https://github.com/flobz/psa_car_controller/blob/master/psa_car_controller/psacc/application/abrp.py#L55) by replacing this part

```py
                response = requests.request("POST", self.url, params=params, proxies=self.proxies,
                                            verify=self.proxies is None, timeout=TIMEOUT_IN_S)

with

                response = requests.request("POST", self.url, params=params, proxies=self.proxies,
                                            verify=True, timeout=TIMEOUT_IN_S)

In a first test the error is gone

flobz commented 7 months ago

the error should appear only if you use proxy no ?

kurim commented 7 months ago

I don't use a proxy server just normal router.

jove01 commented 5 months ago

the error should appear only if you use proxy no ?

So I use NGINX. And what ist the offical way to suppress or to Install the certificate (but i dont like this)