search

floccusaddon / floccus

:cloud: Sync your bookmarks privately across browsers and devices
https://floccus.org
Mozilla Public License 2.0
5.86k stars 241 forks source link

Sync interval #1310

Closed kalekad closed 1 year ago

kalekad commented 1 year ago

Which version of floccus are you using?

v4.18.0

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Tor Browser 12.0.1(Firefox 102.6esr), Android

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I set the sync interval to 5 minutes and save. I reopen the settings and the sync interval is at 15 minutes.

Expected Behavior

A sync interval of 5 minutes remains stored.

To Reproduce

-

Debug log provided

marcelklehr commented 1 year ago

It seems only 5minutes was forbidden due to a legacy rule. Fixed now.

kalekad commented 1 year ago

In v4.18.1 the color of the indicator changed from red to blue when selecting a 5 min interval, but it still does not save.

marcelklehr commented 1 year ago

Confirmed. Weird. I tested this before the release and it was working :/

kolinger commented 12 months ago

Last fix removed one part of condition but identical condition was left few lines bellow: https://github.com/floccusaddon/floccus/blob/8812859e7bed4e9000b117ce0a89d6b56ab5c4ab/src/ui/components/OptionSyncInterval.vue#L49-L61 Where zero index is taken as invalid value and overridden by default 15 minute interval. But zero index is first option of interval and that's 5 minutes, thus 5 minutes is always overridden by 15 minutes.

This is why 5 minute interval still can't be saved with 4.19.1 as #1414 reports and thus this issues wasn't fixed yet.

marcelklehr commented 11 months ago

Thank you @kolinger for investigating this!