floodnet-nyc / flood-sensor

This repo contains source code, manuals, and additional information needed to build, deploy, and maintain a Flood Sensor
https://www.floodnet.nyc
Other
45 stars 12 forks source link

downlink modify duty cycle bug #24

Closed rictolcrow closed 3 years ago

rictolcrow commented 3 years ago

https://github.com/floodsense/floodsense_sensor/blob/47b95f7fdf682df840dd41362ccc281fba2ec586/src/lorawan.cpp#L102

Duty cycle won't update with the D4 header...

try 8*(i-1) i remember that the first bit doesnt needed to be shifted hence i multiplied by i before since there is one byte added as a header we would be using i-1

Praneethsvch commented 3 years ago

bug solved in 0db0efaf8eafbbec5f2b7618c8418ed5ae939a7c