search

florinn / typemoq

A simple mocking library for TypeScript
MIT License
428 stars 45 forks source link

Remove lodash #111

Open styfle opened 6 years ago

styfle commented 6 years ago

It looks like the only usage of lodash is in Match.ts so you're bringing in over a MB of lodash code to do something that takes a couple lines of js.

return x &&
    typeof (x[Consts.IMATCH_MATCHES_NAME]) !== 'undefined' &&
    typeof (x[Consts.IMATCH_ID_NAME]) !== 'undefined' &&
    x[Consts.IMATCH_ID_NAME] === Consts.IMATCH_ID_VALUE;
rakeshvanga commented 4 years ago

I would also like to add that lodash has security vulnerabilities. Can you remove it or update your dependencies?