search

floydwch / kaggle-cli

(Deprecated, use https://github.com/Kaggle/kaggle-api instead) An unofficial Kaggle command line tool.
MIT License
674 stars 92 forks source link

add --zip option to zip the submission file prior to uploading it #52

Open queirozfcom opened 6 years ago

queirozfcom commented 6 years ago

If option is passed, a zip file is created (using python zipfile module) with a random name (cache busting) and the zipped file is uploaded instead, to use less bandwidth. The zip file is deleted afterwards to avoid using up too much disk.

queirozfcom commented 6 years ago

Thanks for the feedback. I'll edit some things and remake the request

queirozfcom commented 6 years ago

I've applied the changes you suggested (except for using config.getboolean(), because the object is not a ConfigParser, but a normal python dict)

queirozfcom commented 6 years ago

@floydwch the changes have been ready for a couple of days now... anything you want to add?

floydwch commented 6 years ago

@queirozfcom sorry, I'm busy now. I'll reply to you ASAP.

floydwch commented 6 years ago

@queirozfcom I added new feedback on the caching issue.

And another concern is, please rebase the commits to the master branch for better commit logs, don't use merge.