fluent / fluent-bit

Fast and Lightweight Logs and Metrics processor for Linux, BSD, OSX and Windows
https://fluentbit.io
Apache License 2.0
5.89k stars 1.59k forks source link

out_prometheus_exporter: Return 204 on no metrics #9614

Open jplitza opened 1 week ago

jplitza commented 1 week ago

Especially when using log_to_metrics or directly after startup, it might well be that no metrics are available yet. This isn't an error condition, so don't return a 4xx code!

Fixes #9366


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

Backporting


Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

jplitza commented 3 days ago

@edsiper Thanks for triggering the Actions! The failing test about in_kubernetes on macos and the failing build on s390x don't seem to be related to my change.