search

fluent / fluent-operator

Operate Fluent Bit and Fluentd in the Kubernetes way - Previously known as FluentBit Operator
Apache License 2.0
555 stars 229 forks source link

Fix release cycles for fluentd and fluentbit images manually. #1183

Closed sarathchandra24 closed 1 month ago

sarathchandra24 commented 1 month ago

What this PR does / why we need it:

https://github.com/fluent/fluent-operator/issues/1178 https://github.com/fluent/fluent-operator/pull/1079

  1. Current Github workflows are following the same release cycle.
  2. We have three different images fluent-bit, fluent-operator and fluentd, but these are on different release cycle and following same tag doesn't apply. Also we don't want to fallback on the make files again.
  3. So instead of creating the images using tags, it asks for a input of what release number to follow and then docker image tags are build likewise.

Links to workflow runs:

  1. Fluent Operator released on tag: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248567473
  2. Fluent Operator released on master: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248514441
  3. Fluent Bit released manually by specifying tag as input for workflow: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248457484
  4. Fluentd released manually by specifying tag as input for workflow: https://github.com/sarathchandra24/fluent-operator/actions/runs/9248735165

How to trigger manually

image

Which issue(s) this PR fixes:

Fixes #1178

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

benjaminhuo commented 1 month ago

That's terrific, thank you! @sarathchandra24

sarathchandra24 commented 1 month ago

Fluentd image build successful for tag 1.15.3: https://github.com/fluent/fluent-operator/actions/runs/9262668827 Fluent Bit image build successful for tag 3.0.4: https://github.com/fluent/fluent-operator/actions/runs/9262666460

benjaminhuo commented 1 month ago

image image

v3.0.4 3.0.4 v3.0 3.0

I can see some extra tag is built v3.0.4 and 3.0.4, v3.0 and 3.0, the helm chart are actually using v3.0.4 only. Is this expected?

@sarathchandra24

sarathchandra24 commented 1 month ago

Yes as per semver thing it is expected, but I can remove it if required. So when ever we release a x.y.z it will also tag x.y to x.y.z. it is controlled over here https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fb-image.yaml#L126-L129 and https://github.com/fluent/fluent-operator/blob/master/.github/workflows/build-fb-image.yaml#L65-L68. I think it's ok to have it, but if you want me to remove it I can raise a PR for it.

benjaminhuo commented 1 month ago

I think it's ok to have it, but if you want me to remove it I can raise a PR for it.

it's ok to keep it, thank you!