fluidex / circuits

GNU Affero General Public License v3.0
10 stars 5 forks source link

refactor: change to include instead of symboliclinking lib/poseidon.circom #180

Closed noel2004 closed 3 years ago

noel2004 commented 3 years ago

Current the file poseidon.circom and poseidon_constants.circom under src/lib is symbolic link to the circomlib of its dependency. Symbolic link may not correctly working under some platform like windows. And the behavior may be unpredicted in case the linked files has another include declaration inside them (to correctly recognize such a declaration circom complier must follow the symbolic link)

So I would advise turn this link into a plain file with only a include declaration inside them. There is also similar including in other files so such an update would be consistent with our code fashions.