Show indicator for validation status

flutter-form-builder-ecosystem / phone_number

Flutter plugin for parsing, formatting and validating international phone numbers.

https://pub.dev/packages/phone_number

BSD 3-Clause "New" or "Revised" License

81 stars 63 forks source link

Show indicator for validation status #76

Closed iamsahilsonawane closed 2 years ago

iamsahilsonawane commented 2 years ago

Connection with issue(s)

Closes #75

Solution description

Shows validation indicator on Validate button press.

Screenshots or Videos

https://user-images.githubusercontent.com/47249618/182874913-0110e807-aa1d-495e-90c6-fac86adf078a.mp4

To Do

[x] Read contributing guide
[x] Check the original issue to confirm it is fully satisfied
[x] Add solution description to help guide reviewers
[ ] Add unit test to verify new or fixed behaviour
[x] If apply, add documentation to code properties and package readme

deandreamatias commented 2 years ago

For me is ok but we need simplify the example in the future to make more easy the understand

iamsahilsonawane commented 2 years ago

About snackbar? Yes now that I am thinking about it, I agree with you.

No problem, I'll remove the utility and call a normal snackbar instead

deandreamatias commented 2 years ago

Its about all, not only the snackbar Complex state managemet for example app, is overthink But of course that isn't your fault or only of this PR, is from old code

iamsahilsonawane commented 2 years ago

I see, let's as add it to the roadmap 👍