flutter-mapbox-gl / maps

A Mapbox GL flutter package for creating custom maps
Other
1.04k stars 502 forks source link

Migration to 10 #691

Open srmncnk opened 3 years ago

srmncnk commented 3 years ago

Any plans on supporting v10?

https://docs.mapbox.com/android/beta/maps/guides/migrate-to-v10/ Looking at the migration guide it seems that there is not much sense in migrating but rather creating a new repo to back the v10 API, since the entire codebase had changed significantly.

Or is there anybody else who's doing the migration somewhere else?

alamboley commented 2 years ago

Hello @tobrun, we've to start a new application where Mapbox and the 3D maps (v10) are required.

We would like to go the Flutter way. Do you know when it will be released? No issue to participate to an open beta. And we've many UI screens to do before the map. Without news we will go with the React Native thanks to https://github.com/rnmapbox/maps

jgrandchavin commented 2 years ago

@tobrun any news about the official Flutter SDK from Mapbox ?

oosafff commented 2 years ago

Hi all, thanks so much for your interest (and patience) around this! I’m a PM at Mapbox and we’re just finalising release planning for the upcoming Mapbox Maps SDK Flutter Plugin. The target is to open the public beta the last week of November. I’ll make sure to ping here once it is out.

@artemsorochan this plugin will only cover Maps SDK. I’m happy to take the topic up with the Navigation team if you can share your use cases with me.

@alamboley if you don’t mind, I’d love to hear more about your 3D map use-cases. We’re continuously working on our 3D pipeline and roadmap, so understanding new use-cases is always of great value.

Feel free to reach out if you have any questions about the upcoming public beta!

felix-ht commented 2 years ago

@oosafff Great to hear - will it have support for web?

AAverin commented 2 years ago

@oosafff And desktop win/linux/mac? I would love to run my product on desktop too.

srmncnk commented 2 years ago

Great news, really looking forward to it.

@alamboley if you don’t mind, I’d love to hear more about your 3D map use-cases. We’re continuously working on our 3D pipeline and roadmap, so understanding new use-cases is always of great value.

@oosafff I'm glad you asked. Though not related to the flutter plugin, an invaluable usecase for 3D would be displaying polygons / points elevated from ground - flight paths, elevated airspaces, points in space etc. Issues for this exist (https://github.com/mapbox/mapbox-gl-js/issues/10174, https://github.com/mapbox/mapbox-gl-js/issues/3993 etc.) and could be pulled of using unity/three on JS but not with pure Mapbox. That would surely put Mapbox ahead of for instance Cesium.

oosafff commented 2 years ago

@felix-ht  @AAverin The plugin is mobile only at this point (Maps SDK for iOS and Android). I can take up web and other requirements with the relevant teams.

@srmanc thanks for the feedback! I’ll bring it up with the 3D team. This is definitely a feature I can see being useful for a wide variety of use-cases.

MatthewPatience commented 2 years ago

Thanks @oosafff , web would be very much appreciated as many of us currently rely upon it in through this plugin. From what we have heard the version of mapbox used by this plugin would stop working in the new year some time, so at a minimum it would be nice to know that it would not be disabled until your new flutter plugin is ready with web+mobile.

AAverin commented 2 years ago

@oosafff Covering other platforms (desktop, web) besides mobile + having a way to do navigation would allow us to expand our product to many more customers. Flutter is unique in this regard, allowing to do so much more than just a mobile app.

We would also love to get 3D maps that were advertised for original mapbox mobile SDKs.

I have about a 100 questions, but will wait for a proper SDK announcement first =)

srmncnk commented 2 years ago

@felix-ht @AAverin The plugin is mobile only at this point (Maps SDK for iOS and Android). I can take up web and other requirements with the relevant teams.

@srmanc thanks for the feedback! I’ll bring it up with the 3D team. This is definitely a feature I can see being useful for a wide variety of use-cases.

@oosafff You're very welcome! Please note that current plugin, started from Mapbox and adopted by @tobrun and then by the community (@felix-ht and @AAverin in particular) does partly support web. Personally I think it's very important to have this unification, especially since a lot of ground work is already done by this plugin.

felix-ht commented 2 years ago

@oosafff i have to say that not having web is a hard blocker for my usecase.

One thing to note is that with the plugin system of flutter it would be possible to just create a flutter web plugin that satiesfies whatever interface is required by the new mapbox flutter package. From my experience with flutter/mapbox on the web this should simple in comparison to the native plugins.

However having first party support for web would be much much better.

felix-ht commented 2 years ago

Thanks @oosafff , web would be very much appreciated as many of us currently rely upon it in through this plugin. From what we have heard the version of mapbox used by this plugin would stop working in the new year some time, so at a minimum it would be nice to know that it would not be disabled until your new flutter plugin is ready with web+mobile.

Note that this plugin it will not be disabled - the only thing that changes is that mapbox won't support the old ios and android code after that point in time. So no more bug fixes from their side for the native code.

AAverin commented 2 years ago

My understanding was that there are no bugfixes to the native code since 2019, no? At least no matter the complaints and attempts to reach out, everything was scoped out in favour of v10 implementation.

felix-ht commented 2 years ago

@AAverin indeed - thats why flutter 3.X was such a pain already

artemsorochan commented 2 years ago

@oosafff Hi, just wanted to ask if there any new forecast on timing? Another clarification is that we want to use Navigation SDK in our app alongside with another web service that changes itinerary of stop points and to update a current route(without finishing and starting a new route). As for now we are sticked to another unofficial plugin with only functionality to start and finish route. Thanks in advance!

kamami commented 2 years ago

Any news regarding the public beta? It is the last week of November - Will the beta be published as planned?

demux79 commented 2 years ago

We might have to wait for the BUILD with Mapbox event on Thursday 🤔

"Mapbox is unveiling our latest features and upgrades on Dec 1 at BUILD with Mapbox, and you’re invited! Learn about our virtual event and register today"

kamami commented 2 years ago

The agenda is not mentioning a possible flutter sdk at all.

demux79 commented 1 year ago

Looks like a delay. Flutter SDK is only listed as "coming soon" at the bottom of the release page.

srmncnk commented 1 year ago

And it looks like Web is ignored completely.

Cortex78 commented 1 year ago

image

Flutter SDK seems Mobile only

AAverin commented 1 year ago

Well, let's hope Android and iOS are bug-free and fully features, so that the only way to go would be to add more platforms, like Web and Desktop =) I have missed the Build event, any announcements made there? What and when can we expect?

felix-ht commented 1 year ago

I asked in the AMA as well - the answer was that they will wait to see how the adoption goes and depending on that add web and desktop support.

Launch will be iOS and Android tho.

Bazni commented 1 year ago

They created a Discord to interact with the community, on it, Chris Wrong from Mapbox said that they plan to publish the public beta on pub.dev next week.

Edit: The link to the message https://discord.com/channels/1004826913229000704/1004826913229000707/1048252161164853348

felix-ht commented 1 year ago

@Bazni can you share the link?

AAverin commented 1 year ago

Well, it should be a big improvement in any case. And there is only one trajectory it can take – become better and support more platforms.

demux79 commented 1 year ago

It is out: https://pub.dev/packages/mapbox_maps_flutter

motrieux-thomas commented 1 year ago

That's a good news!

demux79 commented 1 year ago

Works for me on iOS after I changed the min OS version in mapbox_maps_flutter.podspec from 15 to 11 as stated on pub.dev (I use iOS 12).

However, with Android I get the following issue:

[ ] A problem occurred evaluating project ':mapbox_maps_flutter'.
[ ] > Could not read script '<my local path>/android/gradle/ktlint.gradle' as it does not exist.

I added the token to ~/.gradle/gradle.properties, also tried adding it to /android/grade.properties/ in my app directory to no avail. Flutter clean did not help either.

Do you have any suggestion? I cannot access the Discord mentioned above.

motrieux-thomas commented 1 year ago

Hi @demux79, here is the discord link : https://discord.gg/PEjJHgwm

motrieux-thomas commented 1 year ago

@demux79 I had the same problem, to fix it you need to install ktlint. Here is the link to install it : https://pinterest.github.io/ktlint/install/cli/ You also need to add it on your project, you can follow this tutorial : https://thiagolopessilva.medium.com/configuring-and-running-ktlin-on-android-studio-990ce19b50b6

I'm not sure of the necessity to lint the code in this context, I will ask the team if it's normal :)

srmncnk commented 1 year ago

I took a good look at the new Mapbox plugin. Works as advertised, all in all, kudos @oosafff!

It is derived from the original opensourced project and shares some similarities with the current pre10 community supported plugin.

However there's no web support. And the new plugin is implemented with a lot of private classes that are semi exposed to the outside, making it nearly impossible or at least very hard to extend, implement classes or make a sustainable wrapper, should the community decide to make the effort and try to implement the web version as well. That's a blocker. @oosafff

In that scope I think it makes sense for ur to keep supporting the current plugin and keep reviewing merging PRs and/or find people who can and are willing to help.

Also (and this is a pure mapbox feature request) 3d polygons and polylines would be greatly appreciated: https://github.com/mapbox/mapbox-gl-js/issues/6987, https://github.com/mapbox/mapbox-gl-js/issues/3993, https://github.com/mapbox/mapbox-gl-js/issues/12227 @oosafff

AAverin commented 1 year ago

I saw in Discord that repo for the new SDK should be up soon and everyone will be able to create issues and feature requests there.

m7mdra commented 1 year ago

It is out: https://pub.dev/packages/mapbox_maps_flutter

Sadly its not open source yet , i would've loved to be able to make my own fork and add support to 3d model from 10.6.2.

good job anyway.

JigneshWorld commented 1 year ago

Not an official open-source version, but for the time being, here is the link to explore this specific project version.

https://github.com/motrieux-thomas/mapbox_maps_flutter-0.3.0

cedvdb commented 1 year ago

official repo here https://github.com/mapbox/mapbox-maps-flutter