Skia->engine auto-roller did not close a roll PR that failed CI

flutter / flutter

Flutter makes it easy and fast to build beautiful apps for mobile and beyond

https://flutter.dev

BSD 3-Clause "New" or "Revised" License

164.83k stars 27.16k forks source link

Skia->engine auto-roller did not close a roll PR that failed CI #149740

Open jason-simmons opened 3 months ago

jason-simmons commented 3 months ago

The Skia->engine auto-roller was stuck for a few days because a pending roll PR failed CI: https://github.com/flutter/engine/pull/53162

The linux_web_engine CI check failed on this PR, and the auto-roller should close the PR and start a new roll. But in this case the PR remained open. Creation of new roll PRs did not happen until the failing PR was closed manually.

zanderso commented 3 months ago

@stuartmorgan wondering if this sort of stall could be the result of confusion in cocoon around which database is the source of truth? If this is the first time it's happened in the past several weeks, it might not be worth a deep investigation, though.

stuartmorgan commented 3 months ago

AFAIK Cocoon isn't directly involved in autorollers, it's a whole different system: https://autoroll.skia.org/