fluttercommunity / get_it

Get It - Simple direct Service Locator that allows to decouple the interface from a concrete implementation and to access the concrete implementation from everywhere in your App. Maintainer: @escamoteur
https://pub.dev/packages/get_it
MIT License
1.32k stars 141 forks source link

The license page is wrong with certain fonts. #336

Closed nobushiueshi closed 1 year ago

nobushiueshi commented 1 year ago

When I set up the NotoSansJp font and look at the "get_it" license page, I see mysterious characters.

The reason is that the newline code in the LICENSE file is CRLF.

I changed the line feed code to LF and it cured it.

Noto Sans Japanese

escamoteur commented 1 year ago

sorry, but that is hardly a problem with the package if you use a font that has problems with this.

nobushiueshi commented 1 year ago

@escamoteur The problem is that the newline code in the license file is "CRLF". Please change the newline code to "LF".

escamoteur commented 1 year ago

If it's so important, make PR and fix it please. It's really not my responsibility that your font has problems with it Am 25. Aug. 2023, 20:29 +0200 schrieb nobushiueshi @.***>:

@escamoteur The problem is that the newline code in the license file is "CRLF". Please change the newline code to "LF". — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>