flutterjanus / flutter_janus_client

A plugin that allows the flutter app to communicate with a Janus server using different transport mechanisms, such as WebSocket and HTTP(rest). It features a developer-friendly api to interact with various WebRTC Janus Plugins. Hence, it can be considered as a swiss-knife for WebRTC solutions.
MIT License
134 stars 76 forks source link

Searching transceivers returns wrong result #120

Closed chu06 closed 1 year ago

chu06 commented 1 year ago

While preparing transceivers, searching for audio/video transceiver in the transceiver list returns null even when there is existing audio/video transceiver.

shivanshtalwar0 commented 1 year ago

@all-contributors please add @chu06 for code

allcontributors[bot] commented 1 year ago

@shivanshtalwar0

I've put up a pull request to add @chu06! :tada:

liemfs commented 1 year ago

I just found out, this changes makes muting proces not working, and the data from typedMessages shows unusual data

In version 2.2.13, this is the data from typedMessages after target user doing mute or unmute Mute {videoroom: event, room: 1111111, publishers: [{id: 1111111, display: 1111111, audio_codec: null, video_codec: null, streams: [{disabled: true, description: null, moderated: null, simulcast: null, svc: null, type: audio, mindex: 0, codec: null, mid: 0, fec: null, talking: null}], talking: null}]} Unmute {videoroom: event, room: 1111111, publishers: [{id: 1111111, display: 1111111, audio_codec: opus, video_codec: null, streams: [{disabled: null, description: null, moderated: null, simulcast: null, svc: null, type: audio, mindex: 0, codec: opus, mid: 0, fec: true, talking: null}], talking: null}]}

In version 2.2.14 or 2.2.15 (with this changes included), the data become like this Mute {videoroom: event, room: 1111111, publishers: [{id: 1111111, display: 1111111, audio_codec: opus, video_codec: null, streams: [{disabled: null, description: null, moderated: null, simulcast: null, svc: null, type: audio, mindex: 0, codec: opus, mid: 0, fec: true, talking: null}], talking: null}]} Unmute empty

How this can happen? Help me please

shivanshtalwar0 commented 1 year ago

@liemfs have you tried recent demo of Google meet?

liemfs commented 1 year ago

@shivanshtalwar0 i did, that result come from the example code

shivanshtalwar commented 1 year ago

@liemfs check new version 2.3.0 or demo and let me know if you face any problem

liemfs commented 1 year ago

@shivanshtalwar wow big thanks, i appreciate you, will test latter