handle EINTR return from syscalls

flux-framework / flux-core

core services for the Flux resource management framework

GNU Lesser General Public License v3.0

168 stars 50 forks source link

handle EINTR return from syscalls #3886

Open garlick opened 3 years ago

garlick commented 3 years ago

BTW, you do also guard some of the low level system functions from returning prematurely when being attached to a debugger?

_Originally posted by @dongahn in https://github.com/flux-framework/flux-core/pull/3885#discussion_r719064686_

We are probably OK where libev and 0MQ are making those calls for us, but we may want to audit some other areas like librouter and libsubprocess to make sure attaching with a debugger won't cause spurious failures.

grondo commented 3 years ago

Is it EAGAIN or EINTR?

We should be mostly ok in libsubprocess since most fd read/write calls are wrapped in a cbuf (which of course handles this for us)

garlick commented 3 years ago

libpmi is anther one that might need a look.

dongahn commented 3 years ago

EINTR. Sorry.