search

fluxcd / flux

Successor: https://github.com/fluxcd/flux2
https://fluxcd.io
Apache License 2.0
6.9k stars 1.08k forks source link

Revert "Merge pull request #3381 from jumpeiMano/set-sync-timeout" #3502

Closed kingdonb closed 3 years ago

kingdonb commented 3 years ago

In #3500 a reporter indicates that one of the PRs merged into 1.22.2 was harmful, and causes orphaned data to grow the ephemeral filesystems without cleaning them up. The report says the context was already wrapped in a timeout; I have not been able to spend time to reproduce this issue or delve into the details myself yet.

If this is all correct, I will revert the bad PR and plan to have a new release out early this week.

This reverts commit cf97726492f4b2d9585ded3bd83823ba4e65b272, reversing changes made to 5777baa0c5681565eb3a615a20a8a94961394fb0.

kingdonb commented 3 years ago

According to #3500, this was probably not the fix required. I'm going to close it without merging.