search

fluxcd / flux

Successor: https://github.com/fluxcd/flux2
https://fluxcd.io
Apache License 2.0
6.9k stars 1.08k forks source link

Release 1.25.2 #3615

Closed kingdonb closed 2 years ago

kingdonb commented 2 years ago

Details in the CHANGELOG:

https://github.com/fluxcd/flux/blob/361bc170a813c234596c306f8363de39b6683707/CHANGELOG.md#1252-2022-05-26

kingdonb commented 2 years ago

When reviewing, changes before 9615263 can be disregarded as they have already been reviewed in master.

(The only commit with relevant changes to review is here: 5b93d3c)

I'm intending on fast-tracking a release for this to avoid inconveniencing anyone else who has upgraded, as soon as I get a confirmation in #3611 that it solves the issue from the prerelease build, or as soon as CI passes. (1.25.2 should likely be out today.)

dimbleby commented 2 years ago

will there be a 1.13.1 chart too? Not a big deal either way for me, just asking!

kingdonb commented 2 years ago

@dimbleby You betcha: see #3616

I will need a couple of sign-offs from at least one other maintainer to publish the full release including a chart, that is the major release bottleneck for Flux v1 besides actually composing these PRs.

It has been a big relief to have helpful outside contributors who can report and confirm such issues that may be from weird external dependencies and send a PR to get it fixed. Thanks very much for your contribution here.

I have internalized the release process pretty well now to the point that it takes less than 2 hours from end to end for me to put out a release 👍 the hard part is setting up the repro environment and isolating the actual fix.

dimbleby commented 2 years ago

Super - and thank you so much for jumping on this so quickly

kingdonb commented 2 years ago

Since this fix came from an external contributor, according to the policies for this repo I am able to approve and merge the PR for prerelease and again for release without any secondary approvals. I cannot publish the chart before I get those approvals though. If this is a high priority for you and you need the chart, please let me know and I will follow up then.

It should all be ready early next week anyway, if that's soon enough 👍