fluxcd / helm-controller

The GitOps Toolkit Helm reconciler, for declarative Helming
https://fluxcd.io
Apache License 2.0
404 stars 161 forks source link

Reintroduce missing events for helmChart reconciliation failures #907

Closed souleb closed 6 months ago

souleb commented 6 months ago

fixes 4649

If implemented this PR reintroduces events for some failing actions during the reconciliation process, related to the chart retrieval and loading of chart and values.

We do not reintroduce all events (still available in logs), but where it is desirable to have notifications in place.

souleb commented 6 months ago

Testing with a faulty configmap gives us:

{"level":"info","ts":"2024-03-06T11:09:39.678Z","logger":"event-server","msg":"dispatching event","eventInvolvedObject":{"kind":"HelmRelease","namespace":"backend","name":"redis","uid":"50f43354-d991-4149-bd7f-31074eed9a83","apiVersion":"helm.toolkit.fluxcd.io/v2beta2","resourceVersion":"625589"},"message":"could not resolve ConfigMap chart values reference 'backend/application-values-g9g5b268dh' with key 'values.yaml': key not found"}
Status:
  Conditions:
    Last Transition Time:  2024-03-06T11:10:17Z
    Message:               Fulfilling prerequisites
    Observed Generation:   8
    Reason:                Progressing
    Status:                True
    Type:                  Reconciling
    Last Transition Time:  2024-03-06T11:10:17Z
    Message:               could not resolve ConfigMap chart values reference 'backend/application-values-g9g5b268dh' with key 'values.yaml': key not found
    Observed Generation:   8
    Reason:                ValuesError
    Status:                False
    Type:                  Ready