Resolve compiler warnings

[CapnBry]

Compiler warnings were pointing to a couple errors in the code

• Squid_Network::addMessage() was using sizeof on array pointers, which return 4, not the size of the array.
• RUNTIME.fly_mode == SD_MODE_FLY; code has no effect

I also took the liberty of fixing all the other compiler warnings as well. I will note that some of the source files have Unix line endings (yay) but others have Windows line endings (boooo), however I just matched the unit's line endings. The code still won't compile in Arduino IDE 2.1.0, which seems to treat all warnings as errors for some reason. There are a bunch of unused variables, variables that are set but never used, squid_params_t with inline initializers (which converts it to a non-trivial type), and a switch statement that doesn't handle all the options. These you'd need to decide if you want to remove them or use them so I did not modify those.

Appreciate you putting out this neat little tool for letting me test my RID implementations 🤩

[truglodite]

This should fix the warnings I was seeing in IDE 2.1.1 with compiler warnings set to "default". It will compile set to default, but it won't compile if keep my normal setting of "verbose". So I think the warnings setting affects whether it errors out on warnings or not.

[flyandi]

thank you so much. merged.

[CapnBry]

It will compile set to default, but it won't compile if keep my normal setting of "verbose".

Aha! I knew it had to be a setting somewhere, because the code compiled in Arduino 1.8.x after my changes, but not in 2.1.x with the same core. Compiler warnings needs to be set to Default or None. This is only the second time I've used 2.1.x after using Arduino IDE for over a decade so I may have inadvertently turned this on during the transition (as the setting is in 1.8.x too). Thanks for the pointer!