flyx / NimYAML

YAML implementation for Nim
https://nimyaml.org
Other
191 stars 36 forks source link

Compatiblity with Nim v1.4 #88

Closed jfilby closed 3 years ago

jfilby commented 4 years ago

Compilation fails after upgrading to Nim v1.4:

.nimble/pkgs/yaml-0.14.0/yaml/serialization.nim(407, 18) Error: attempting to call undeclared routine: 'getGMTime'

It looks like this function is no longer available in the times module.

flyx commented 4 years ago

This has already been fixed in #84, which has not yet made it into a release. In the meantime, you can install yaml#head.

telatin commented 4 years ago

I tried using yaml#head in a .nimble file, but got this during compilation with nim 1.2.4:

[...]yaml-#head/yaml/data.nim(131, 28) Error: undeclared identifier: 'FieldDefect'

It's not urgent and I can work with a pathed 0.14 meanwhile, just reporting in case others have the same problem

flyx commented 4 years ago

@telatin FieldDefect is part of the system module since 1.4.0 (introduced here). HEAD doesn't support older compiler versions.

telatin commented 4 years ago

Thanks for clarifying! I installed nim 1.4.0, but now nimble install yaml#head does not work, did also nimble syntax change?

flyx commented 4 years ago

Syntax seems to be nimble install yaml@#head now.

jfilby commented 3 years ago

Works fine now (last tested with Nim 1.4.4).