Closed fmang closed 3 years ago
I am sorry, but unistd.h
should be included, not stdlib.h
, on FreeBSD: https://www.freebsd.org/cgi/man.cgi?query=mkstemp&sektion=3
Sincestdlib.h
is also missing for Linux, maybe a correct patch is to add:
#include <stdlib.h>
#if defined(__FreeBSD__)
#include <unistd.h>
#endif
Wow, I did not expect that.
Let’s include both headers unconditionally for better compatibility, in case there are other BSDs that would require unistd too.
Let’s merge this. @yurivict Would you like me to release it as 1.5.1 or do you fetch master?
@yurivict Would you like me to release it as 1.5.1 or do you fetch master?
I would prefer a release.
Thank you.
@yurivict Alright! Before that, may I ask you to ensure that the new --edit feature works as expected? It integrates with the system editor and calls the shell, so even if I think the implementation is portable, who knows what may happen. You can invoke it like EDITOR=vim opustags -e in.opus -o out.opus
.
Ok. I will check this feature when I will update the port.
@yurivict If you will I’d like you to test it before I release, in case you find another issue.
@fmang Can you add to the README links to good opus file examples to test it with, because the links on https://opus-codec.org/ are broken.
I tested the current master on FreeBSD 12.2. The --edit
feature works.
There's also this patch in the port that can be upstreamed:
--- src/opus.cc.orig 2020-11-08 09:32:46 UTC
+++ src/opus.cc
@@ -23,6 +23,7 @@
#include <opustags.h>
+#include <sys/endian.h>
#include <string.h>
#ifdef __APPLE__
Close #41
@yurivict Could you please try to build this branch?