search

fmarotta / kaobook

A LaTeX class for books, reports or theses based on https://github.com/kenohori/thesis and https://github.com/Tufte-LaTeX/tufte-latex.
https://github.com/fmarotta/kaobook
LaTeX Project Public License v1.3c
862 stars 186 forks source link

kaobiblio: fix \sideparencite command (was not printing in margin) #212

Closed Dettorer closed 2 years ago

Dettorer commented 2 years ago

The \sideparencite helper command was indeed calling \parencite but without adding anything to the side margin.

This change fixes it in my document but I'm not familiarized enough with the kaobook codebase to be sure of what I'm doing, so please don't hesitate to ask me to improve this PR.

What I did was basically mimick the way \sidetextcite combines the functionalities of \textcite and \sidecite and try to make this variant do the same.

I don't personally use it but \sidesupercite seems a bit faulty too, it adds something to the side margin but not with the same level of details, should I try and make it look like other citation types as well?

fmarotta commented 2 years ago

Thanks! I didn't notice. If you don't change \sidesupercite I'll probably do it anyway, so feel free to improve it if you have the time.

fmarotta commented 2 years ago

But see also #222