fmjstudios / helm

🪖 A collection of MIT-licensed Helm Charts
MIT License
13 stars 13 forks source link

(linkwarden) fix: Configmap helm template fix (SSO), replicas parameter #13

Closed kehralexander closed 10 months ago

kehralexander commented 11 months ago

What this PR does / why we need it

I think there's a spot in the configmap template that was overlooked when cherry-picking #4.
I've also added the replica parameter again, as linkwarden should support multiple replicas as outlined in https://github.com/fmjstudios/helm/pull/4#issuecomment-2282329508

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

mvprowess commented 10 months ago

Hey @kehralexander, thank you for your changes! I somehow missed those. My bad for leaving you hanging so long again, I missed the notification 🤦🏼

While I'm still not quite sure about the stability of the change, I guess taking that risk should really be up to the user. I was going to try to get in contact with the Linkwarden maintainer within the next few weeks anyways, so I guess he'll be able to offer some insight on that. I'll be sure to update the doc comments in the values whenever I've had the chance.

I've merged and released your changes! 👍🏼

kehralexander commented 10 months ago

@FMJdev Thank you very much!