[ntfy] No args send to the Docker container. Get the NTFY help instead of launching the server

timoa commented 6 months ago

Name and Version

fmjstudios/helm/ntfy:0.2.2

What architecture are you using?

amd64

What steps will reproduce the bug?

Deploy the Helm chart without values (after fixing the #19 issue)
The pod is created, but backoff
In the log, we can see that it shows the ntfy help with the list of available commands and options

Are you using any custom parameters or values?

No (I fixed locally the #19 issue)

What is the expected behavior?

It is supposed to launch the ntfy server with the arguments set on the Helm Chart

What do you see instead?

It shows the ntfy help with the list of commands and options.

Additional information

There is no args value sent to the container like:

args: [ "serve" ]

Edo78 commented 5 months ago

I'm fiddling around with this chart and it seems to need args: ["serve", "--config", "/var/lib/ntfy/config.yml"] otherwise none of the option will made it through... I'll do some more tests ASAP and I'll open a PR as soon as I'll feel comfortable

Edo78 commented 5 months ago

I'm sorry, I'd like to try and work on a PR but I can't even find the time to install the tools to contribute properly ... BTW as far as I checked I found a couple od points that needs some care

*** ntfy/templates/configmap.yaml   2025-02-04 08:08:07.047280816 +0100
--- /home/edo/My_Stuff/ntfy-test-chart/ntfy/templates/configmap.yaml    2025-01-28 00:07:33.808820972 +0100
***************
*** 16,20 ****
  data:
    config.yml: |
!     base-url: {{ .Values.ntfy.baseURL }}
      listen-http: {{ .Values.ntfy.listenHTTP }}
      web-root: {{ .Values.ntfy.webRoot }}
--- 16,20 ----
  data:
    config.yml: |
!     base-url: 'https://{{ .Values.ntfy.baseURL }}'
      listen-http: {{ .Values.ntfy.listenHTTP }}
      web-root: {{ .Values.ntfy.webRoot }}
diff --color -C 2 ntfy/templates/_podSpec.yaml /home/edo/My_Stuff/ntfy-test-chart/ntfy/templates/_podSpec.yaml
*** ntfy/templates/_podSpec.yaml    2025-02-04 08:08:07.047280816 +0100
--- /home/edo/My_Stuff/ntfy-test-chart/ntfy/templates/_podSpec.yaml 2025-01-27 00:20:29.169663893 +0100
***************
*** 41,44 ****
--- 41,45 ----
          image: {{ include "ntfy.image" . }}
          imagePullPolicy: {{ .Values.image.pullPolicy }}
+         args: ["serve", "--config", "/var/lib/ntfy/config.yml"]
          env:
              {{- if (or .Values.ntfy.smtp.senderUser .Values.ntfy.smtp.existingSecret) }}

As I use a only https I needed to set a prefix on base_url while the added args was @timoa discovery. Sorry if I can't be more helpfull but time is a scarse resource

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

fmjstudios / helm